[16.0][ADD] partner_invoicing_mode_cash_on_delivery #1736
Conversation
rousseldenis
force-pushed
the
16.0-add-partner-invoicing-mode-cash-on-delivery-dro
branch
from
1736850 to
2e2bb89
Compare
partner_invoicing_mode_cash_on_delivery/models/account_payment_mode.py
Outdated
Show resolved
Hide resolved
rousseldenis
force-pushed
the
16.0-add-partner-invoicing-mode-cash-on-delivery-dro
branch
from
0e47e46 to
199be84
Compare
|
Hi @rousseldenis could you check this PR ? thanks a lot :) |
rousseldenis
force-pushed
the
16.0-add-partner-invoicing-mode-cash-on-delivery-dro
branch
from
42b08c6 to
cb70061
Compare
|
@OCA/accounting-maintainers This one is ready |
rousseldenis
force-pushed
the
16.0-add-partner-invoicing-mode-cash-on-delivery-dro
branch
from
cb70061 to
3ace259
Compare
|
@OCA/accounting-maintainers Can we get this PR merged ? |
|
This PR looks fantastic, let's merge it! |
|
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1736-by-rafaelbn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@rousseldenis Can you rebase ? |
|
@rousseldenis reminder ;) |
| """ | ||
| self.ensure_one() | ||
| res = super()._invoice_at_shipping() | ||
| res = res or self.sale_id.payment_mode_id.cash_on_delivery |
There was a problem hiding this comment.
Invoicing should be triggered only for outgoing pickings. Here is the fix acsone#5
|
@rousseldenis Can you rebase ? Another unrelated module is failing |
… to print cash on delivery invoices
The aim was to extract logic that depends on shipment_advice to have a separate module to manage cash on delivery process independently.
Do not trigger invoicing on internal operations
rousseldenis
force-pushed
the
16.0-add-partner-invoicing-mode-cash-on-delivery-dro
branch
from
51a38d1 to
ad415fa
Compare
This work is based on : OCA/stock-logistics-transport#118
Depends on:
I've extracted the logic about cash on delivery to make it independent from shipment_advice process (as we only need it to print related invoices there). That's why I want also to keep initial commit.